fix: prevent intra-process tempfile collisions in atomic store writes - #33
Open
adi-IL wants to merge 1 commit into
Open
fix: prevent intra-process tempfile collisions in atomic store writes#33adi-IL wants to merge 1 commit into
adi-IL wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeRecord writes record state to
${recordPath(key)}.tmp.${process.pid}before renaming it into place.When rapid asynchronous events occur within the same Node.js process (e.g. concurrent state updates or logging hooks), concurrent calls share the exact same temporary filename. This can cause partial overwrites and rename failures.
Use a unique per-operation nonce for the temporary file and clean up on write errors.