Skip to content

Commit

Permalink
Fix a few misc bugs due to unused code
Browse files Browse the repository at this point in the history
  • Loading branch information
dzbarsky committed Jul 31, 2023
1 parent c09d207 commit 70f5c9d
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 9 deletions.
3 changes: 0 additions & 3 deletions arn/generator.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ import (
"strings"
)

type ARN struct {
}

type Generator struct {
AwsAccountId string
Region string
Expand Down
6 changes: 0 additions & 6 deletions services/kinesis/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,12 +215,6 @@ type APIStartingPosition struct {
Timestamp int64
}

type SubscribeToShardOutput struct {
EventStream struct {
SubscribeToShardEvent APISubscribeToShardEvent
}
}

type APISubscribeToShardEvent struct {
ContinuationSequenceNumber string
MillisBehindLatest int32
Expand Down
1 change: 1 addition & 0 deletions services/kms/http.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ func (k *KMS) RegisterHTTPHandlers(logger *slog.Logger, methodRegistry http.Regi
http.Register(logger, methodRegistry, service, "CreateKey", k.CreateKey)
http.Register(logger, methodRegistry, service, "Decrypt", k.Decrypt)
http.Register(logger, methodRegistry, service, "DeleteAlias", k.DeleteAlias)
http.Register(logger, methodRegistry, service, "DescribeKey", k.DescribeKey)
http.Register(logger, methodRegistry, service, "DisableKey", k.DisableKey)
http.Register(logger, methodRegistry, service, "EnableKey", k.EnableKey)
http.Register(logger, methodRegistry, service, "Encrypt", k.Encrypt)
Expand Down
5 changes: 5 additions & 0 deletions services/s3/s3.go
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,11 @@ func (s *S3) AbortMultipartUpload(input AbortMultipartUploadInput) (*Response204
return nil, awserrors.XXX_TODO("bad upload status")
}

if upload.Bucket != input.Bucket || upload.Key != input.Key {
// TODO: check this behavior
return nil, awserrors.XXX_TODO("bad upload")
}

upload.Status = UploadStatusCompleted
return response204, nil
}
Expand Down

0 comments on commit 70f5c9d

Please sign in to comment.