Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: Add support for parsing keys and creation date from under ilst atom. #25

Merged
merged 7 commits into from
Mar 10, 2024
Merged

improvement: Add support for parsing keys and creation date from under ilst atom. #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ac14c8e
improvement: Add support for parsing keys and creation date from unde…
dtrejod Dec 29, 2023
20800ae
Parse timestamp from keys.
dtrejod Jan 15, 2024
8710896
lint.
dtrejod Jan 15, 2024
56c42a5
remove uneeded setting ctx.
dtrejod Jan 15, 2024
59929ce
Vendor latest go-mp4.
dtrejod Mar 10, 2024
358fc90
Just use mvhd creation time since it matches ilst.
dtrejod Mar 10, 2024
9d268a3
Remove override.
dtrejod Mar 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module github.com/dtrejod/goexif
go 1.20

require (
github.com/abema/go-mp4 v1.1.1
github.com/abema/go-mp4 v1.2.0
github.com/corona10/goimagehash v1.1.0
github.com/dsoprea/go-exif/v3 v3.0.1
github.com/h2non/filetype v1.1.3
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
github.com/abema/go-mp4 v1.1.1 h1:OfzkdMO6SWTBR1ltNSVwlTHatrAK9I3iYLQfkdEMMuc=
github.com/abema/go-mp4 v1.1.1/go.mod h1:vPl9t5ZK7K0x68jh12/+ECWBCXoWuIDtNgPtU2f04ws=
github.com/abema/go-mp4 v1.2.0 h1:gi4X8xg/m179N/J15Fn5ugywN9vtI6PLk6iLldHGLAk=
github.com/abema/go-mp4 v1.2.0/go.mod h1:vPl9t5ZK7K0x68jh12/+ECWBCXoWuIDtNgPtU2f04ws=
github.com/benbjohnson/clock v1.1.0 h1:Q92kusRqC1XV2MjkWETPvjJVqKetz1OzxZB7mHJLju8=
github.com/corona10/goimagehash v1.1.0 h1:teNMX/1e+Wn/AYSbLHX8mj+mF9r60R1kBeqE9MkoYwI=
github.com/corona10/goimagehash v1.1.0/go.mod h1:VkvE0mLn84L4aF8vCb6mafVajEb6QYMHl2ZJLn0mOGI=
Expand Down
6 changes: 0 additions & 6 deletions internal/moovdata/moov.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ var (
// mvhdBoxPath is the BoxPath to the MVHD Box that contains Creation Time metadata
// Ref: https://developer.apple.com/documentation/quicktime-file-format/movie_header_atom/creation_time
mvhdBoxPath mp4.BoxPath = []mp4.BoxType{mp4.BoxTypeMoov(), mp4.BoxTypeMvhd()}
// metaBoxPath is the BoxPath to the Meta Box the contains tags that may contain a CreationDate tag key
// Ref: https://developer.apple.com/documentation/quicktime-file-format/metadata_atom
//metaBoxPath mp4.BoxPath = []mp4.BoxType{mp4.BoxTypeMeta()}
)

// GetTime return the CreationTime from a MooV file
Expand All @@ -29,9 +26,6 @@ func GetTime(path string) (time.Time, error) {
func getTimeFromBoxes(boxes []*mp4.BoxInfoWithPayload) (time.Time, error) {
for _, box := range boxes {
switch t := box.Payload.(type) {
case *mp4.Meta:
// TODO: Parse tags once go-mp4 supports parsing tags from the Meta box
// https://github.com/abema/go-mp4/issues/13
case *mp4.Mvhd:
return timeSince1904(t.CreationTimeV0), nil
}
Expand Down
7 changes: 6 additions & 1 deletion vendor/github.com/abema/go-mp4/README.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions vendor/github.com/abema/go-mp4/box_info.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 35 additions & 0 deletions vendor/github.com/abema/go-mp4/box_types_iso23001_5.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

85 changes: 85 additions & 0 deletions vendor/github.com/abema/go-mp4/box_types_metadata.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions vendor/github.com/abema/go-mp4/mp4.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions vendor/github.com/abema/go-mp4/read.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/modules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# github.com/abema/go-mp4 v1.1.1
# github.com/abema/go-mp4 v1.2.0
## explicit; go 1.14
github.com/abema/go-mp4
github.com/abema/go-mp4/internal/bitio
Expand Down
Loading