improvement: Add support for parsing keys and creation date from under ilst atom. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrejod
commented
Dec 29, 2023
dtrejod
commented
Jan 15, 2024
internal/moovdata/moov.go
Outdated
Comment on lines
78
to
84
| // prefer ilst timestamp | ||
| if ilstTs != nil { | ||
| return (*ilstTs).UTC(), nil | ||
| } | ||
| if mvhdTs != nil { | ||
| return (*mvhdTs).UTC(), nil | ||
| } |
There was a problem hiding this comment.
From inspecting a few exported iOS Photos.app media files, I have found that the ilst and mvhd CreationTimestamp are equal.. I'm not sure when these may differ after probing a few examples..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
I thought we needed to path the list atom in order to find the most accurate date time for moov files. However after some testing, I found most iPhone moov files correctly set the mvhd atom with the relevant creation time date.
After this PR
No changes. Just bump to latest go-mp4 pkg.
Requires: abema/go-mp4#159