Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(livenet): some fixes related to getting live image size #2611

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(livenet): some fixes related to getting live image size #2611

wants to merge 3 commits into from

Commits on Jan 19, 2024

  1. fix(livenet): propagate error code

    @aafeijoo-suse
    aafeijoo-suse committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    38ad209 View commit details
    Browse the repository at this point in the history

  2. fix(livenet): check also content-length from live image header 

    Some servers send `content-length` instead of `Content-Length`, so ignore the
case. E.g.:

```
> curl -sIL https://pkg.adfinis.com/opensuse/tumbleweed/iso/openSUSE-Tumbleweed-DVD-x86_64-Snapshot20240118-Media.iso
HTTP/2 200
server: nginx
date: Fri, 19 Jan 2024 16:29:54 GMT
content-type: application/octet-stream
content-length: 4643094528
last-modified: Fri, 19 Jan 2024 03:34:00 GMT
etag: "65a9eda8-114c00000"
accept-ranges: bytes
```
    @aafeijoo-suse
    aafeijoo-suse committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ac37c6a View commit details
    Browse the repository at this point in the history

  3. fix(livenet): split imgsize calculation to avoid misleading error m… 

    …essage

If `curl` fails to reach the URL of the live image, or if the header received
does not provide `Content-Length`, the error message displayed is misleading.

```
[    8.118432] dracut-initqueue[800]: /usr/sbin/livenetroot: line 21: / (1024 * 1024): syntax error: operand expected (error token is "/ (1024 * 1024)")
```

Therefore, split the calculation and provide proper error messages.

Reported-by: Knut Anderssen <[email protected]>
    @aafeijoo-suse
    aafeijoo-suse committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    4dbb962 View commit details
    Browse the repository at this point in the history