fix(livenet): some fixes related to getting live image size #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some servers send `content-length` instead of `Content-Length`, so ignore the case. E.g.: ``` > curl -sIL https://pkg.adfinis.com/opensuse/tumbleweed/iso/openSUSE-Tumbleweed-DVD-x86_64-Snapshot20240118-Media.iso HTTP/2 200 server: nginx date: Fri, 19 Jan 2024 16:29:54 GMT content-type: application/octet-stream content-length: 4643094528 last-modified: Fri, 19 Jan 2024 03:34:00 GMT etag: "65a9eda8-114c00000" accept-ranges: bytes ```
…essage If `curl` fails to reach the URL of the live image, or if the header received does not provide `Content-Length`, the error message displayed is misleading. ``` [ 8.118432] dracut-initqueue[800]: /usr/sbin/livenetroot: line 21: / (1024 * 1024): syntax error: operand expected (error token is "/ (1024 * 1024)") ``` Therefore, split the calculation and provide proper error messages. Reported-by: Knut Anderssen <[email protected]>
|
CC @tblume |
github-actions
bot
added
modules
LGTM |
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
3 tasks
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes related to getting live image size.
Checklist