Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve transformation of who attributes #28

Merged
merged 6 commits into from
Sep 2, 2024
Merged

Improve transformation of who attributes #28

merged 6 commits into from
Sep 2, 2024

Commits on Sep 2, 2024

  1. Remove special casing of misspelled 'who' attributes

    @cmil
    cmil committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    d584d36 View commit details
    Browse the repository at this point in the history

  2. Fall back to speaker when encountering empty who 

    Before we only used the speaker tags when no who attribute values
were found at all. This has never been the case recently because all
documents as far as they include 'sp' elements also provide who
attributes. Just sometimes these may be empty.
    @cmil
    cmil committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2258f8b View commit details
    Browse the repository at this point in the history

  3. Regenerate with improved who attibute handling 

    Relies on dracor branch changes:
dracor-org/theatre-classique@9745b8a
dracor-org/theatre-classique@182fb34
    @cmil
    cmil committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    ddb8ff0 View commit details
    Browse the repository at this point in the history

  4. Revise the transformation of speaker IDs 

    We now recognize the underscore as an additional separator of individual speaker IDs
when multiple speakers occur in an sp. This requires fixing the the use of underscores
in other cases on the dracor branch.

We also use a more sophisticated approach to transform IDs starting with a number, which we now move to the end of the ID.
    @cmil
    cmil committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    313af9e View commit details
    Browse the repository at this point in the history

  5. Regenerate with revised speaker ID handling and ID fixes on the draco… 

    …r branch
    @cmil
    cmil committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    7478321 View commit details
    Browse the repository at this point in the history

  6. Remove fixing of element names 

    This should be done on the dracor branch of the sources.
    @cmil
    cmil committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    7cef7ae View commit details
    Browse the repository at this point in the history