Improve transformation of who attributes
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmil
force-pushed
the
20-speakers
branch
2 times, most recently
from
590a57e
to
474ef0f
Compare
lucagiovannini7
approved these changes
Sep 2, 2024
Before we only used the speaker tags when no who attribute values were found at all. This has never been the case recently because all documents as far as they include 'sp' elements also provide who attributes. Just sometimes these may be empty.
Relies on dracor branch changes: dracor-org/theatre-classique@9745b8a dracor-org/theatre-classique@182fb34
We now recognize the underscore as an additional separator of individual speaker IDs when multiple speakers occur in an sp. This requires fixing the the use of underscores in other cases on the dracor branch. We also use a more sophisticated approach to transform IDs starting with a number, which we now move to the end of the ID.
This should be done on the dracor branch of the sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aims to make the transformation of
whoattributes andcastListelements in the theatre-classique sources into FreDraCorparticDescelements more robust. Instead of trying to fix the mistakes and oddities in the sources programmatically it attempts to implement the rules inherent in them. From now on, in the sources, we expect the following:whoattributes to be correctly spelledwhoattribute are separated by either comma, underscore or forward slash (an " et " will not be considered a separator)Deviations from these rules need to be corrected on the
dracorbranch of the theatre-classique repo. In fact, most of the TEI changes in this PR have already been originated by changes in thedracorbranch. See https://github.com/dracor-org/theatre-classique/compare/dracor for details.resolve #15
resolve #20