Skip to content

Fix flaky help_options test: restore enableConsoleColoring after mutation #19385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T-Gro merged 3 commits into from
Mar 6, 2026
+12 −6
Merged

Fix flaky help_options test: restore enableConsoleColoring after mutation #19385

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aab1be9
Initial plan
Copilot Mar 3, 2026
a283880
Fix flaky help_options test by saving/restoring enableConsoleColoring…
Copilot Mar 3, 2026
ffc248f
Merge branch 'main' into copilot/fix-flaky-help-options-test
T-Gro Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions tests/FSharp.Compiler.ComponentTests/CompilerOptions/fsc/FscOptionTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace CompilerOptions.Fsc

open Xunit
open FSharp.Compiler.CompilerOptions
open FSharp.Test.Compiler

module FscOptionTests =
Expand Down Expand Up @@ -59,12 +60,17 @@ module FscOptionTests =
[<InlineData("--consolecolors-")>]
[<Theory>]
let ``fsc --consolecolors switch`` option =
Fs """printfn "Hello, World" """
|> asExe
|> withOptions [option]
|> compile
|> shouldSucceed
|> ignore
let saved = enableConsoleColoring

try
Fs """printfn "Hello, World" """
|> asExe
|> withOptions [option]
|> compile
|> shouldSucceed
|> ignore
finally
enableConsoleColoring <- saved

// --preferreduilang

Expand Down
Loading