Migrated B5 style guide to webpack #36108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which is more standard
This commit also does light linting (whitespace changes) and adds ES6-style imports.
In webpack, hq.helpers is in the standard commcarehq bundle.
orangejenny
added
the
product/admin
orangejenny
requested review from
millerdev,
AmitPhulera,
gherceg and
jingcheng16
millerdev
approved these changes
Mar 31, 2025
This was referenced Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
This looks long, but it's pretty mechanical. Review by commit.
Safety Assurance
Safety story
This is technically public but probably not used outside of Dimagi. I've tested each page locally, comparing with the style guide on staging.
Automated test coverage
no
QA Plan
not requesting QA
Rollback instructions
Labels & Review