Removed javascript_libraries template tag #36119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimagimon
added
Risk: High
millerdev
approved these changes
Mar 31, 2025
| @@ -131,6 +131,104 @@ | |||
|
|
|||
| {% if not use_js_bundler %} | |||
| {% javascript_libraries use_bootstrap5=use_bootstrap5 underscore=True jquery_ui=request.use_jquery_ui ko=True hq=True analytics=True %} | |||
There was a problem hiding this comment.
What do you think of adding a comment to this block to the effect of
{# Everything in this `if not use_js_bundler`-block below this line can be removed once all of app manager, including form builder, is on webpack. #}It doesn't seem obvious, and seems like it could be easily forgotten.
There was a problem hiding this comment.
I will not forget 🙂 I've got a note to get rid of use_js_bundler altogether. But adding a comment sounds fine - 0969128
|
I'm temporarily reverting #36073, so marking this "don't merge" until that's re-reverted. |
millerdev
approved these changes
Mar 31, 2025
millerdev
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
#36108 removed the last usage of this tag.
This does move a long chunk of code to
hqwebapp/base.html, but it can be removed once all of app manager, including form builder, is on webpack.Safety Assurance
Safety story
Removal of dead code.
Automated test coverage
no
QA Plan
no
Rollback instructions
Labels & Review