Skpkg: update pyobjcryst #53
Conversation
Migrate deprecated calls on matplotlib,
pkg_resources, pyobjcryst, distutils
pcmt: simple pre-commit hook fixes
__init__:
noqa: F401 on gTopRefinableObjRegistry
import. Removing it will cause potential api
breakage on downstream users. Also Exist at
pyobjcryst.globals
crystal.py:
Add except type (AttributeError)
at UpdateDisplay(self) to avoid E722.
fourier.py:
noqa E741 on ambigous variable
name 'l'. (hkl)
globaloptim.py:
clarify refinableobj imports
lsq.py:
Expose LSQ from c++ extension
powderpattern.py:
Add except type (AttributeError)
at UpdateDisplay(self) to avoid E722.
Add except type (AttributeError, RuntimeError, ValueError)
at plot() (Force immediate display) with
warning messages "Plot refresh failed..."
Add except type (AttributeError, RuntimeError)
at _do_plot_hkl (Force immediate display). Nested
utils.py:
change lambda function to def
pcmt on tests
There was a problem hiding this comment.
we will have to turn of nbstripout and restore the examples ipynbs as Vincent wants them to have the outputs.
Pleae also remove the skpkg logo and replace it with an empty .placeholder file
Other than that, I will merge it to the migration branch and we can start testing it and having @vincefn look it over.
@vincefn these changes are designed to allow it to be released to PyPI and conda-forge automatically in the future using GH scripts. Hopefully nothing is broken and no functionality changes, but it brings the code into line with all the diffpy packages for easier maintenance in the future.
We will attaempt a pre-release from the migration branch and we can test everything and if we are happy with it we can merge to main and do a release all the way to PyPI and conda-forge.
| ;; See https://docs.openverse.org/meta/codespell.html for docs. | ||
|
|
||
| ;; ORTHORHOMBIC | ||
| ORTHOROMBIC |
There was a problem hiding this comment.
this seems like it is likely an actual typo....is there are reason we want to escape it?
There was a problem hiding this comment.
@sbillinge I decided not to correct them as it was inherited from libobjcryst. I can correct about half of this typos in pyobjcryst but not all of them, and this will make using pyobjcryst different from directly using libobjcryst...
There was a problem hiding this comment.
ok, let's leave them like this for now.
| build: | ||
| os: "ubuntu-22.04" | ||
| tools: | ||
| python: "mambaforge-latest" |
There was a problem hiding this comment.
we may want to check these changes with @vincefn. Not sure why mambaforge is specified in the original.
There was a problem hiding this comment.
@sbillinge I think this is only for documentations. I was planning to figure that out later as now the documentations (2024 versions) are not rendering correctly
| @@ -1,16 +1,13 @@ | |||
| recursive-include src * | |||
| include SConstruct | |||
There was a problem hiding this comment.
@sbillinge
We already have new "graft src" so I think the first line is ok. I also checked locally and it looks fine.
I rewrite SCons stuff and now they are solely for development use. Better to let the users using pip or conda directly
| [project] | ||
| name = "pyobjcryst" | ||
| dynamic=['version', 'dependencies'] | ||
| authors = [ |
There was a problem hiding this comment.
Let's have @vincefn and @pavoljuhas and @cfarrow as the main authors
|
@Tieqiong is this passing tests? Do we know why CI is not running tests? btw, I change the base to be a new clean migration branch. The old one had some work from Caden, but that work has been duplicated in this PR so it is nothing lost. |
Yes this is passing matrix tests. I'm not exactly sure why the CI is not running but I guess it might because this is my first contribution here? |
replace #52
@sbillinge please check, thanks! Maybe we should merge this to a separate branch?
Fix pcmt
Rewrite SCons so now fast/debug builds for development is back, add a bit documentations
Migrate deprecated calls on matplotlib, pkg_resources, libobjcryst, distutils
Update to skpkg standard