Skpkg: update pyobjcryst #52
Closed
+4,092
−9,683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate deprecated calls on matplotlib,
pkg_resources, pyobjcryst, distutils
pcmt: simple pre-commit hook fixes
__init__:
noqa: F401 on gTopRefinableObjRegistry
import. Removing it will cause potential api
breakage on downstream users. Also Exist at
pyobjcryst.globals
crystal.py:
Add except type (AttributeError)
at UpdateDisplay(self) to avoid E722.
fourier.py:
noqa E741 on ambigous variable
name 'l'. (hkl)
globaloptim.py:
clarify refinableobj imports
lsq.py:
Expose LSQ from c++ extension
powderpattern.py:
Add except type (AttributeError)
at UpdateDisplay(self) to avoid E722.
Add except type (AttributeError, RuntimeError, ValueError)
at plot() (Force immediate display) with
warning messages "Plot refresh failed..."
Add except type (AttributeError, RuntimeError)
at _do_plot_hkl (Force immediate display). Nested
utils.py:
change lambda function to def
pcmt on tests
Merged
|
seems like upstream/migrate is not clean. Will make a new PR to main! replaced by #53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sbillinge please check, thanks!
Fix pcmt
Rewrite SCons so now fast/debug builds for development is back, add a bit documentations
Migrate deprecated calls on matplotlib, pkg_resources, libobjcryst, distutils
Update to skpkg standard