feat: Add higher level cost APIs #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
michael-weigelt
commented
Mar 10, 2025
michael-weigelt
commented
Mar 10, 2025
Comment on lines
+629
to
+631
| let algorithm = match arg.key_id.algorithm { | ||
| SchnorrAlgorithm::Bip340secp256k1 => 0, | ||
| SchnorrAlgorithm::Ed25519 => 1, |
There was a problem hiding this comment.
What do you think about associating this mapping with the type directly, e.g. as impl Into<u32>?
There was a problem hiding this comment.
I think that's a good idea.
michael-weigelt
changed the title
lwshang
approved these changes
Mar 10, 2025
lwshang
added a commit
that referenced
this pull request
Mar 10, 2025
…der the hood (#570) * update ic0 to include cost_* API * add api bindings * e2e test api bindings * management_canister methods handles cycles under the hood * changelog * typo * add Errors section in docs * fill changelog * distinguish api.rs bindings and management_canister.rs methods * feat: Add higher level cost APIs (#574) * added high level endpoints to mgmt cost api * add cost for performing call * typo * apply review suggestions * improve cross reference in docs * impl Into<u32> for curve and algo * changelog * lint suggests From trait --------- Co-authored-by: michael-weigelt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged or cherry-picked into #570