Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cost_* System API and methods that calculate cycles cost under the hood #570

Merged
merged 16 commits into from
Mar 10, 2025

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Mar 5, 2025

SDK-1963

Description

  • Updated ic0 according to Add system API endpoints for cycle cost calculation portal#4110.
  • Added bindings for cost_* System API in api.rs.
  • Removed the _with_cycles suffix from some Management canister methods
    • They no longer takes cycles as an argument.
    • The cycles cost is calculated inside by invoking the new cost_* API.

Note: No binding for cost_vetkd_derive_encrypted_key because the corresponding Management canister methods hasn't been included.

How Has This Been Tested?

Updated related e2e tests.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang changed the base branch from main to next March 5, 2025 19:18
@lwshang lwshang marked this pull request as ready for review March 5, 2025 19:31
@lwshang lwshang requested a review from a team as a code owner March 5, 2025 19:31
@lwshang lwshang requested a review from michael-weigelt March 5, 2025 19:31
@lwshang lwshang requested a review from michael-weigelt March 10, 2025 16:19
@lwshang lwshang merged commit 37cd64f into next Mar 10, 2025
11 checks passed
@lwshang lwshang deleted the lwshang/SDK-1963_cost_api branch March 10, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants