Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lopper: Ensure Only Existing DT Node Parameters #493

Merged
merged 1 commit into from
Mar 5, 2025
Merged

lopper: Ensure Only Existing DT Node Parameters #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lopper/assists/baremetal_xparameters_xlnx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#/*
# * Copyright (c) 2020 Xilinx Inc. All rights reserved.
# * Copyright (c) 2024 Advanced Micro Devices, Inc. All rights reserved.
# * Copyright (c) 2024 - 2025 Advanced Micro Devices, Inc. All rights reserved.
# *
# * Author:
# * Appana Durga Kedareswara rao <[email protected]>
Expand Down Expand Up @@ -244,6 +244,7 @@ def xlnx_generate_xparams(tgt_node, sdt, options):
except KeyError:
_warning(f"Get interrupt id is failed {node.name}, adding default value as {[0xFFFF]}")
intr_id = [0xFFFF]
continue

elif prop == "interrupt-parent":
try:
Expand Down Expand Up @@ -334,6 +335,7 @@ def xlnx_generate_xparams(tgt_node, sdt, options):
except KeyError:
_warning(f"Get property value is failed for {prop} and node is {node.name}, adding default value as {0}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this warning message we need to update we should say proprery is not present in the device-tree so not generating define in xparamers.h file same is true for above intr_id case as well

@zeddii : Please don't merge the loppers/assists/b* and lopper/assists/gen_domain_dts changes until me or onkar approves the changes.

prop_val = [0]
continue

if pad:
address_prop = ""
Expand Down