lopper: Ensure Only Existing DT Node Parameters #493
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a continue statement in the for loop to skip parameters that do not exist in the DT node. This prevents unnecessary population of non-existent parameters in xparameters.h Signed-off-by: Preethi Cherakula <[email protected]>
| @@ -334,6 +335,7 @@ def xlnx_generate_xparams(tgt_node, sdt, options): | |||
| except KeyError: | |||
| _warning(f"Get property value is failed for {prop} and node is {node.name}, adding default value as {0}") | |||
There was a problem hiding this comment.
this warning message we need to update we should say proprery is not present in the device-tree so not generating define in xparamers.h file same is true for above intr_id case as well
@zeddii : Please don't merge the loppers/assists/b* and lopper/assists/gen_domain_dts changes until me or onkar approves the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a continue statement in the for loop to skip parameters that do not exist in the DT node. This
prevents unnecessary population of non-existent
parameters in xparameters.h