fix: add NetworkPolicy RBAC permissions - #1690
Conversation
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe controller and deployment manifests now grant create, delete, get, list, patch, update, and watch permissions for ChangesNetworkPolicy RBAC
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
47a5b81 to
0a27c97
Compare
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
0a27c97 to
ac6c2b2
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rohanKanojia, tolusha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What does this PR do?
Add kubebuilder RBAC for
networking.k8s.io/networkpolicies(create,delete,update,patch,get,list,watch) on the DevWorkspaceRouting controller.What issues does this PR fix or reference?
Operators are expected to be able to manage NetworkPolicy resources for their operands. The CSV currently only requests
networking.k8s.io/ingresses.Is it tested? How?
make generate_all(include those manifests in this PR or a follow-up commit before merge).0.43.x(also needed onmainif not cherry-picked later).PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with CheSummary by CodeRabbit