Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifier Client Args by specifying default args #150

Merged
merged 5 commits into from
Nov 29, 2024
Merged

Conversation

Iamdavidonuh
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Nov 29, 2024

Test Results

153 tests   153 ✅  2m 43s ⏱️
  8 suites    0 💤
  2 files      0 ❌

Results for commit 58b22c3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 29, 2024

Benchmark Results

group                                                        main                                   pr
-----                                                        ----                                   --
store_batch_insertion_without_predicates/size_100            1.00    819.9±6.38µs        ? ?/sec    1.02   834.5±13.30µs        ? ?/sec
store_batch_insertion_without_predicates/size_1000           1.01      9.6±0.08ms        ? ?/sec    1.00      9.5±0.05ms        ? ?/sec
store_batch_insertion_without_predicates/size_10000          1.10     95.6±1.49ms        ? ?/sec    1.00     86.8±4.07ms        ? ?/sec
store_batch_insertion_without_predicates/size_100000         1.00   886.2±73.74ms        ? ?/sec    1.08    960.4±4.85ms        ? ?/sec
store_retrieval_no_condition/size_100                        1.00      2.6±0.06ms        ? ?/sec    1.01      2.7±0.01ms        ? ?/sec
store_retrieval_no_condition/size_1000                       1.01     19.7±0.24ms        ? ?/sec    1.00     19.6±0.26ms        ? ?/sec
store_retrieval_no_condition/size_10000                      1.00    189.4±2.17ms        ? ?/sec    1.01    190.7±4.06ms        ? ?/sec
store_retrieval_no_condition/size_100000                     1.00  1922.6±24.46ms        ? ?/sec    1.00  1917.3±40.03ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_100                   1.00      2.8±0.01ms        ? ?/sec    1.01      2.9±0.06ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_1000                  1.00     21.4±0.27ms        ? ?/sec    1.00     21.4±0.27ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_10000                 1.00    206.1±1.94ms        ? ?/sec    1.02    209.4±2.86ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_100000                1.00       2.1±0.02s        ? ?/sec    1.02       2.1±0.03s        ? ?/sec
store_sequential_insertion_without_predicates/size_100       1.00  1729.6±47.13µs        ? ?/sec    1.01  1755.1±51.19µs        ? ?/sec
store_sequential_insertion_without_predicates/size_1000      1.00     17.3±0.28ms        ? ?/sec    1.05     18.1±0.21ms        ? ?/sec
store_sequential_insertion_without_predicates/size_10000     1.04    183.2±5.38ms        ? ?/sec    1.00    176.0±1.90ms        ? ?/sec
store_sequential_insertion_without_predicates/size_100000    1.00  1772.7±47.02ms        ? ?/sec    1.02  1803.6±15.67ms        ? ?/sec

@Iamdavidonuh Iamdavidonuh requested review from deven96 and HAKSOAT and removed request for deven96 November 29, 2024 15:59
Copy link
Owner

@deven96 deven96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deven96 deven96 merged commit 4ed3ad4 into main Nov 29, 2024
5 checks passed
@deven96 deven96 deleted the david/type-builder branch November 29, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants