Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ahnlich CLI rewrite with Raw mode enabled #125

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Conversation

Iamdavidonuh
Copy link
Collaborator

@Iamdavidonuh Iamdavidonuh commented Oct 3, 2024

Some things that were included in this PR include

  • Command highlighting: We could opt to go for keyword highlighting by simply extending existing words in the commands to show that they are keywords
  • Ctrl-C binding: This now exits the CLI as it should
  • Ctrl-L binding: This clears the screen
  • Fixed some issues with deleting characters and cursor getting yanked to the very end
  • HistoryManager: Loads and saves history to ~/.ahnlich_cli_history. On command enter, the history is updated in memory and also on disk to allow easy navigation with Up and Down arrows

@Iamdavidonuh Iamdavidonuh requested a review from deven96 October 3, 2024 02:11
Copy link

github-actions bot commented Oct 3, 2024

Test Results

137 tests   137 ✅  1m 34s ⏱️
  8 suites    0 💤
  2 files      0 ❌

Results for commit f8b67d7.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 3, 2024

Benchmark Results

group                                                        main                                   pr
-----                                                        ----                                   --
store_batch_insertion_without_predicates/size_100            1.00    849.8±3.21µs        ? ?/sec    1.01   860.7±22.54µs        ? ?/sec
store_batch_insertion_without_predicates/size_1000           1.11      9.7±0.09ms        ? ?/sec    1.00      8.7±0.28ms        ? ?/sec
store_batch_insertion_without_predicates/size_10000          1.08     96.0±0.34ms        ? ?/sec    1.00     89.3±3.37ms        ? ?/sec
store_batch_insertion_without_predicates/size_100000         1.00    971.1±4.65ms        ? ?/sec    1.03   997.5±32.28ms        ? ?/sec
store_retrieval_no_condition/size_100                        1.02      2.6±0.05ms        ? ?/sec    1.00      2.5±0.02ms        ? ?/sec
store_retrieval_no_condition/size_1000                       1.03     19.5±0.59ms        ? ?/sec    1.00     19.0±0.28ms        ? ?/sec
store_retrieval_no_condition/size_10000                      1.01    187.6±2.62ms        ? ?/sec    1.00    185.0±2.41ms        ? ?/sec
store_retrieval_no_condition/size_100000                     1.03  1918.5±73.86ms        ? ?/sec    1.00  1853.6±31.49ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_100                   1.00      2.7±0.04ms        ? ?/sec    1.00      2.8±0.02ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_1000                  1.00     20.3±0.19ms        ? ?/sec    1.02     20.8±0.46ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_10000                 1.00    202.9±1.11ms        ? ?/sec    1.01    204.4±4.71ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_100000                1.00       2.1±0.03s        ? ?/sec    1.00       2.1±0.03s        ? ?/sec
store_sequential_insertion_without_predicates/size_100       1.01  1798.2±21.68µs        ? ?/sec    1.00  1772.1±22.48µs        ? ?/sec
store_sequential_insertion_without_predicates/size_1000      1.00     17.8±0.26ms        ? ?/sec    1.00     17.8±0.44ms        ? ?/sec
store_sequential_insertion_without_predicates/size_10000     1.03    177.5±2.54ms        ? ?/sec    1.00    172.6±5.82ms        ? ?/sec
store_sequential_insertion_without_predicates/size_100000    1.08  1758.3±54.02ms        ? ?/sec    1.00  1631.4±14.68ms        ? ?/sec

@deven96 deven96 marked this pull request as ready for review October 4, 2024 01:24
@deven96 deven96 force-pushed the david/ahnlich-cli branch from 3658dbd to cdf31a8 Compare October 4, 2024 01:34
@deven96 deven96 force-pushed the david/ahnlich-cli branch from cdf31a8 to f8b67d7 Compare October 4, 2024 01:37
@deven96 deven96 merged commit 1f0bc6a into main Oct 4, 2024
5 checks passed
@Iamdavidonuh Iamdavidonuh deleted the david/ahnlich-cli branch October 6, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants