Skip to content

feat: fully remove Deno.serveHttp API #31282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: fully remove Deno.serveHttp API #31282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runtime/js/90_deno_ns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import * as net from "ext:deno_net/01_net.js";
import * as tls from "ext:deno_net/02_tls.js";
import * as serve from "ext:deno_http/00_serve.ts";
import * as http from "ext:deno_http/01_http.js";

Check failure on line 18 in runtime/js/90_deno_ns.js

View workflow job for this annotation

GitHub Actions / lint debug linux-x86_64 

`http` is never used

Check failure on line 18 in runtime/js/90_deno_ns.js

View workflow job for this annotation

GitHub Actions / lint debug macos-x86_64 

`http` is never used

Check failure on line 18 in runtime/js/90_deno_ns.js

View workflow job for this annotation

GitHub Actions / lint debug windows-x86_64 

`http` is never used
import * as websocket from "ext:deno_http/02_websocket.ts";
import * as errors from "ext:runtime/01_errors.js";
import * as version from "ext:runtime/01_version.ts";
Expand Down Expand Up @@ -138,7 +138,7 @@
permissions: permissions.permissions,
Permissions: permissions.Permissions,
PermissionStatus: permissions.PermissionStatus,
serveHttp: http.serveHttp,
// serveHttp: http.serveHttp,
serve: serve.serve,
resolveDns: net.resolveDns,
upgradeWebSocket: websocket.upgradeWebSocket,
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/js_unit_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ util::unit_test_factory!(
get_random_values_test,
globals_test,
headers_test,
http_test,
// http_test,
image_bitmap_test,
image_data_test,
internals_test,
Expand Down
Loading