Skip to content

Conversation

@bartlomieju
Copy link
Member

While technically a breaking change, this API has been soft-deprecated since Deno 1.46 and
hard deprecated in Deno 2 - there are no type declarations nor documentation for this API.

I want to give it a go and remove it for the Deno 3 RC releases and see the impact.

Copilot AI review requested due to automatic review settings November 13, 2025 18:00
Copilot finished reviewing on behalf of bartlomieju November 13, 2025 18:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated Deno.serveHttp API which has been soft-deprecated since Deno 1.46 and hard deprecated in Deno 2, in preparation for Deno 3 RC releases.

Key changes:

  • Commented out the serveHttp export from the Deno namespace
  • Disabled the http_test unit test that validates the removed API

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
runtime/js/90_deno_ns.js Comments out the serveHttp export from the Deno namespace to prevent access to the deprecated API
tests/integration/js_unit_tests.rs Comments out the http_test unit test registration since it tests the now-removed API

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@iuioiua
Copy link
Contributor

iuioiua commented Nov 13, 2025

I suggest doing the same for Deno.run, Deno.stderr.rid, Deno.stdin.rid, Deno.stdout.rid and Deno.isatty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants