Skip to content

Fix on() prototype queue option handling #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanbmilbourne wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix on() prototype queue option handling #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,13 +276,15 @@ rpc.prototype.call = function(cmd, params, cb, context, options) {
* Non-durable queues (transient queues) are purged if/when a server restarts.
* Note that durable queues do not necessarily hold persistent messages,
* although it does not make sense to send persistent messages to a transient queue.

* Defaults to false.
* @param {boolean} options.exclusive Exclusive queues may only be accessed by the current connection,
* and are deleted when that connection closes.
* Defaults to false.
* @param {boolean} options.autoDelete If true, the queue is deleted when all consumers have finished using it.
* The last consumer can be cancelled either explicitly or because its channel is closed.
* If there was no consumer ever on the queue, it won't be deleted. Applications
* can explicitly delete auto-delete queues using the Delete method as normal.
* Defaults to true.
* @return {boolean}
*/

Expand All @@ -292,11 +294,16 @@ rpc.prototype.on = function(cmd, cb, context, options) {
if(this.__cmds[ cmd ]) return false;
options || (options = {});

var durable = (typeof options.durable === 'undefined' ? false : options.durable)
, exclusive = (typeof options.exclusive === 'undefined' ? false : options.exclusive)
, autoDelete = (typeof options.autoDelete === 'undefined' ? true : options.autoDelete)
;

var $this = this;

this._connect(function() {

$this.__conn.queue(options.queueName || cmd, function(queue) {
$this.__conn.queue(options.queueName || cmd, {durable: durable, exclusive: exclusive, autoDelete: autoDelete}, function(queue) {
$this.__cmds[ cmd ] = { queue: queue };
queue.subscribe(function(message, d, headers, deliveryInfo) {

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"amqp",
"rpc"
],
"version": "0.0.8",
"version": "0.0.9",
"preferGlobal": true,
"author": {
"name": "Eugene Demchenko"
Expand Down