Fix on() prototype queue option handling
#17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where the on() function prototype was not creating its queue with the options passed to it (exclusive, durable, autoDelete). The code is modified to create an object that is passed to the amqp library. The option contains the properties durable, exclusive and autoDelete. Defaults match node-amqp's defaults. Tested against node-amqp 0.2.4 and RabbitMQ 3.3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where the on() function prototype was not
creating its queue with the options passed to it (exclusive, durable,
autoDelete). The code is modified to create an object that is passed to
the amqp library. The option contains the properties durable, exclusive
and autoDelete.
Defaults match node-amqp's defaults.
Tested against node-amqp 0.2.4 and RabbitMQ 3.3.5