feat: make graphql queries compatible with new Squid #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanmahidalgo
commented
Aug 5, 2024
| @@ -33,7 +33,11 @@ export function createNFTsHandler( | |||
| const isLand = params.getBoolean('isLand') | |||
| const isOnRent = params.getBoolean('isOnRent') | |||
| const isWearableHead = params.getBoolean('isWearableHead') | |||
| ? params.getString('isWearableHead') === 'true' | |||
There was a problem hiding this comment.
This change is needed to know if it needs to be applied in the query as parameter or not
https://github.com/decentraland/nft-server/pull/380/files#diff-d1debe4191e7ee45f023c53cecc0a2d6c05c4dba8f24d44c3a2c69261102a0bcR310
juanmahidalgo
commented
Aug 5, 2024
| $isWearableHead: Boolean | ||
| $isWearableAccessory: Boolean) { | ||
|
|
||
| const variablesBasedOnFilters = Object.entries(filters) |
There was a problem hiding this comment.
the variables in the GraphQL query must be used somewhere in the query, so this new logic is to put them in dynamically just if they are being used after.
LautaroPetaccio
approved these changes
Aug 5, 2024
Comment on lines
+108
to
+110
| const variablesBasedOnFilters = Object.entries(filters) | ||
| .filter(([key, value]) => value !== undefined && key in PRICES_FILTERS_DICT) | ||
| .map(([key]) => (PRICES_FILTERS_DICT[key] ? PRICES_FILTERS_DICT[key] : '')) |
There was a problem hiding this comment.
What do you think about abstracting this mechanism so we can use it in all of these queries?
There was a problem hiding this comment.
Sure, great idea, let me prepare that in a following up PR so we can review that exclusively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.