fix: fix ambiguous id ORDER in the catalog query when filtering by te…

…xt (#353)

* fix: fix ambiguous id ORDER in the catalog query when filtering by text

* test: fix broken test

src/ports/catalog/queries.ts

@@ -32,7 +32,7 @@ export function getOrderBy(filters: CatalogFilters) {
 
   if (search) {
     // If the filters have a search term, we need to order by the position of the item in the search results that is pre-computed and passed in the ids filter.
-    return SQL`ORDER BY array_position(${filters.ids}::text[], id) `
+    return SQL`ORDER BY array_position(${filters.ids}::text[], items.id) `
   }
 
   let sortByQuery:

src/tests/ports/catalog-queries.spec.ts

@@ -415,7 +415,7 @@ test('catalog utils', () => {
         it('should ORDER BY the ids order in the array', () => {
           const orderBy = getOrderBy({ search, ids }) as SQLStatement
           expect(orderBy.text).toContain(
-            `ORDER BY array_position($1::text[], id) `
+            `ORDER BY array_position($1::text[], items.id) `
           )
           expect(orderBy.values).toContain(ids)
         })