Update sqlglot dependency
#409
Closed
+120
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ 36/36 passed, 1 flaky, 4 skipped, 33m26s total Flaky tests:
Running from acceptance #502 |
|
Superseded by #409. |
asnare
added a commit
that referenced
this pull request
Jun 25, 2025
The 26.30.0 release of sqlglot introduced a breaking change that affects our tests; this PR is a quick-fix to prevent that version from being used. This PR also includes type-hinting fixes that newer versions of mypy need, along with accompanying fixes for issues that the improved type-hints expose. For now this is intended to: - Unblock databrickslabs/blueprint#248. - Supersede #409.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates some tests that were broken due to some breaking changes introduced in sqlglot 26.30.0 (tobymao/sqlglot#5240).
It also deals with some linting issues that appeared: newer versions of mypy are stricter, which meant updating some inaccurate type-hints and fixing various things that this exposed.
The fixes here address problems already present on
main, and are currently blocking databrickslabs/blueprint#248 due to the downstream checks performance by the CI for blueprint.