Skip to content

Limit sqlglot to releases earlier than 26.30.0. #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

Limit sqlglot to releases earlier than 26.30.0. #410

merged 2 commits into from
Jun 25, 2025

Conversation

asnare
Copy link
Contributor

@asnare asnare commented Jun 24, 2025

The 26.30.0 release of sqlglot introduced a breaking change that affects our tests; this PR is a quick-fix to prevent that version from being used.

This PR also includes type-hinting fixes that newer versions of mypy need, along with accompanying fixes for issues that the improved type-hints expose.

For now this is intended to:

@asnare asnare self-assigned this Jun 24, 2025
@asnare asnare added dependencies Pull requests that update a dependency file tech debt labels Jun 24, 2025
@asnare asnare requested review from sundarshankar89, a team and gueniai June 24, 2025 14:28
@asnare asnare added this to UCX Jun 24, 2025
@asnare asnare moved this to Ready for Review in UCX Jun 24, 2025
@asnare asnare requested a review from a team June 24, 2025 14:29
Copy link

✅ 36/36 passed, 4 skipped, 31m30s total

Running from acceptance #503

@asnare asnare enabled auto-merge (squash) June 24, 2025 15:58
Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asnare asnare merged commit 3472e4a into main Jun 25, 2025
8 checks passed
@asnare asnare deleted the pin-sqlglot branch June 25, 2025 08:39
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in UCX Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file tech debt
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants