Fixes try_add_state in actor state manger #756
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Kolevska <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
- Coverage 86.63% 86.05% -0.58%
==========================================
Files 84 87 +3
Lines 4473 4783 +310
==========================================
+ Hits 3875 4116 +241
- Misses 598 667 +69 ☔ View full report in Codecov by Sentry. |
3 tasks
lor1113
added a commit
to lor1113/python-sdk
that referenced
this pull request
Dec 3, 2024
Fixing bug in try_add_state as mentioned in PR dapr#756 Co-authored-by: Elena Kolevska <[email protected]> Signed-off-by: Lorenzo Curcio <[email protected]>
lor1113
added a commit
to lor1113/python-sdk
that referenced
this pull request
Dec 3, 2024
Fixing bug in try_add_state as mentioned in PR dapr#756 Co-authored-by: Elena Kolevska <[email protected]> Signed-off-by: Lorenzo Curcio <[email protected]> Signed-off-by: Lorenzo Curcio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the behaviour of
try_add_statein the actor state manager. Namely, the method would throw an error saying a key already exists when it doesn't.Issue reference
#755
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: