Mock Actor merge attempt 2 (see desc) #750
Conversation
Signed-off-by: Lorenzo Curcio <[email protected]>
There was a problem hiding this comment.
I'm sorry I haven't gotten to this PR yet, we're all really busy with the 1.15 release.
I noticed you renamed one of the docs files. I think we should revert that change, because this .md is shown directly in the dapr docs: https://docs.dapr.io/developing-applications/sdks/python/python-actor/.
Also, please move the new docs you added in the existing page.
lor1113
force-pushed
the
mock-actors-3
branch
from
b449f3c
to
6406b8d
Compare
Signed-off-by: Lorenzo Curcio <[email protected]>
lor1113
force-pushed
the
mock-actors-3
branch
from
6406b8d
to
aee0fe0
Compare
|
The file was renamed such that it would be able to have sub-files, like how the main "Extensions" page under the Python SDK documentation is called "index.md" (https://docs.dapr.io/developing-applications/sdks/python/python-sdk-extensions/) with the idea that the mock actor documentation could be confined to a sub-file for brevity. Requested changes have been made regardless. It's now simply appended to the end of the current actor documentation. |
Signed-off-by: Lorenzo Curcio <[email protected]>
New merge request made due to manually copying changes into a new branch being seemingly the only way to avoid weird git diff issues.
Description
Added Mock Actor capability.
NOTE: Due to not being able to get dapr-docs running in its own dev container despite repeated attempts (I am simply not a frontend coder so i don't know how to debug all the weird errors it was spitting out), I have not been able to actually view the new documentation within a running instance of the website. I have written it nonetheless using the same templating as the others, as well as basic markdown syntax, but it would be appreciated if someone who has a develop version of the docs website working on their machine could just give it a quick look to make sure it's not somehow broken.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #737
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: