Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkstyle strange behavior #973

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Fix checkstyle strange behavior #973

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c20db3a
set sourceDirectory of checkstyle plugin to only check the sources di…
skyao Dec 14, 2023
9330edf
Merge branch 'master' into fix-checkstyle
skyao Dec 19, 2023
7f7d7d8
hard code upload-artifact version to 3.0.0
skyao Dec 19, 2023
35b5fe9
Merge branch 'master' into fix-checkstyle
cicoyle Dec 22, 2023
60aa835
Merge branch 'master' into fix-checkstyle
artursouza Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,24 +126,24 @@ jobs:
id: integration_tests
run: PRODUCT_SPRING_BOOT_VERSION=${{ matrix.spring-boot-version }} ./mvnw -B -f sdk-tests/pom.xml verify
- name: Upload test report for sdk
uses: actions/upload-artifact@master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this from master to v3.0.0 - did you encounter an issue that warranted this change?

uses: actions/upload-artifact@v3.0.0
with:
name: report-dapr-java-sdk
path: sdk/target/jacoco-report/
- name: Upload test report for sdk-actors
uses: actions/upload-artifact@master
uses: actions/upload-artifact@v3.0.0
with:
name: report-dapr-java-sdk-actors
path: sdk-actors/target/jacoco-report/
- name: Upload failsafe test report for sdk-tests on failure
if: ${{ failure() && steps.integration_tests.conclusion == 'failure' }}
uses: actions/upload-artifact@master
uses: actions/upload-artifact@v3.0.0
with:
name: failsafe-report-sdk-tests
path: sdk-tests/target/failsafe-reports
- name: Upload surefire test report for sdk-tests on failure
if: ${{ failure() && steps.integration_tests.conclusion == 'failure' }}
uses: actions/upload-artifact@master
uses: actions/upload-artifact@v3.0.0
with:
name: surefire-report-sdk-tests
path: sdk-tests/target/surefire-reports
Expand Down
3 changes: 3 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,9 @@
<failOnViolation>true</failOnViolation>
<failsOnError>true</failsOnError>
<linkXRef>false</linkXRef>
<sourceDirectories>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in the open issue on this, you mentioned that there are in fact checkstyle violations. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check locally. I do not see those same failures/warnings showing up in CI now. Maybe we should add that command you ran locally to CI and only merge once there are no checkstyle violations.

<sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
</sourceDirectories>
</configuration>
<executions>
<execution>
Expand Down
Loading