Fix checkstyle strange behavior #973
Conversation
…rectory, not test source and generated source Signed-off-by: Sky Ao <[email protected]>
.github/workflows/build.yml
Outdated
| @@ -126,24 +126,24 @@ jobs: | |||
| id: integration_tests | |||
| run: PRODUCT_SPRING_BOOT_VERSION=${{ matrix.spring-boot-version }} ./mvnw -B -f sdk-tests/pom.xml verify | |||
| - name: Upload test report for sdk | |||
| uses: actions/upload-artifact@master | |||
There was a problem hiding this comment.
Why change this from master to v3.0.0 - did you encounter an issue that warranted this change?
| @@ -195,6 +195,9 @@ | |||
| <failOnViolation>true</failOnViolation> | |||
| <failsOnError>true</failsOnError> | |||
| <linkXRef>false</linkXRef> | |||
| <sourceDirectories> | |||
There was a problem hiding this comment.
I see in the open issue on this, you mentioned that there are in fact checkstyle violations. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check locally. I do not see those same failures/warnings showing up in CI now. Maybe we should add that command you ran locally to CI and only merge once there are no checkstyle violations.
Signed-off-by: Artur Souza <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
=========================================
Coverage 76.29% 76.29%
Complexity 1463 1463
=========================================
Files 138 138
Lines 4497 4497
Branches 524 524
=========================================
Hits 3431 3431
Misses 784 784
Partials 282 282 ☔ View full report in Codecov by Sentry. |
Description
Set sourceDirectory of checkstyle plugin to only check the sources directory, not test source directory / generated source directory.
Issue reference
More details please see issue:
#972
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: