[components] Refactor component load behavior #27181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
OwenKephart
force-pushed
the
01-16-_components_refactor_component_load_behavior
branch
from
977ee0c to
3c6e30f
Compare
benpankow
approved these changes
Jan 17, 2025
| component_file_model=obj, | ||
| source_position_tree=parsed.source_position_tree, | ||
| ) | ||
|
|
||
| def get_component_type(self, registry: ComponentTypeRegistry) -> type[Component]: |
There was a problem hiding this comment.
nit: get_ belies that this is doing some real work (parsing python files), maybe resolve_component_type?
There was a problem hiding this comment.
might be worth a brief docstr to explain that this does local lookup in addition to the expected registry lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This moves the load method onto the individual DeclNode classes, which simplifies the logic a bit and just generally is a bit better organized.
The impetus for this is cleaning up the house a bit in preparation for adding a PythonDeclNode
How I Tested These Changes
Changelog
NOCHANGELOG