Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components] Explicitly pass params to Component.load #27174

Open
wants to merge 1 commit into
base: 01-16-_components_rename_get_params_schema_type
Choose a base branch
from

Conversation

OwenKephart
Copy link
Contributor

@OwenKephart OwenKephart commented Jan 16, 2025

Summary & Motivation

This makes way for a new PythonComponentDecl that I'd like to add upstack, but I also just think this is net a better implementation regardless.

In particular, the fact that we needed to call loaded_params = context.load_params(cls.get_schema()) in every single load() method was a big red flag.

How I Tested These Changes

Changelog

NOCHANGELOG

Copy link
Contributor Author

OwenKephart commented Jan 16, 2025

@OwenKephart OwenKephart changed the title [components] Explicitly pass params [components] Explicitly pass params to Component.load Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant