-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6/n][dagster-sling] Update docs with DagsterSlingTranslator.get_asset_spec #27168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
Merged
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-5
branch
from
January 16, 2025 19:10
47b221d
to
b470f66
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-6
branch
from
January 16, 2025 19:10
c71e8d3
to
3ada061
Compare
OwenKephart
approved these changes
Jan 17, 2025
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-5
branch
from
January 17, 2025 16:57
b470f66
to
1ba176a
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-6
branch
from
January 17, 2025 16:57
3ada061
to
dc63fa0
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-5
branch
from
January 20, 2025 19:58
1ba176a
to
efdad6c
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-6
branch
from
January 20, 2025 19:58
dc63fa0
to
9d19c7f
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-5
branch
from
January 20, 2025 20:16
efdad6c
to
e8cb217
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-6
branch
from
January 20, 2025 20:16
9d19c7f
to
8139528
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-5
branch
from
January 20, 2025 21:07
e8cb217
to
b1b03d6
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-6
branch
from
January 20, 2025 21:07
8139528
to
0485097
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-5
branch
from
January 20, 2025 21:57
b1b03d6
to
a94e26f
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-6
branch
from
January 20, 2025 21:57
0485097
to
06401de
Compare
cmpadden
approved these changes
Jan 20, 2025
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-5
branch
from
January 20, 2025 22:19
a94e26f
to
709f5fa
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-6
branch
from
January 20, 2025 22:19
06401de
to
d1d10d7
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-6
branch
from
January 20, 2025 22:56
d1d10d7
to
b328003
Compare
marijncv
pushed a commit
to marijncv/dagster
that referenced
this pull request
Jan 21, 2025
…t_spec (dagster-io#27168) ## Summary & Motivation Update docstring examples to use get_asset_spec. Also fixes a docstring that was incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Update docstring examples to use get_asset_spec. Also fixes a docstring that was incorrect.