[2/n][dagster-sling] Move logic to default fns in DagsterSlingTranslator #27140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 16, 2025
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-1
branch
from
b4209ba to
741906e
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-2
branch
from
03baef5 to
0dfb519
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-1
branch
from
741906e to
63ae4eb
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-2
branch
from
0dfb519 to
a2508f5
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -155,6 +194,32 @@ def get_deps_asset_key(self, stream_name: str) -> AssetKey: | |||
| return AssetKey(map[stream_name]) | |||
|
|
|||
| """ | |||
| return self._default_deps_fn(stream_definition) | |||
|
|
|||
| def _default_deps_fn(self, stream_definition: Mapping[str, Any]) -> Iterable[AssetKey]: | |||
There was a problem hiding this comment.
The parameter type in the function signature is incorrect. The method accepts stream_definition: Mapping[str, Any] but the docstring still references stream_name: str. This should be updated to match the actual implementation and maintain consistency with the other translator methods.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Move the logic in
DagsterSlingTranslator.get_*methods toDagsterSlingTranslator._default_*_fnmethodsThis is motivated by two main reasons:
get_asset_specimplementation as clean as possible in subsequent PR.DagsterSlingTranslator.get_*methods will be deprecated in a subsequent PR, but it would be great to keep to docstrings in the code after these will be removed, to help users if needed.How I Tested These Changes
Existing tests with BK