[daggy-u] Example code fixes for extra credit lesson in Dagster Essentials #25418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphite-app
bot
added
area: dagster-university
cmpadden
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Hi @aleexharris, thanks for taking the time to update the lesson.
It's much appreciated!
Grzyblon
pushed a commit
to Grzyblon/dagster
that referenced
this pull request
Oct 26, 2024
…tials (dagster-io#25418) ## Summary & Motivation One example code snippet was missing an import (`MaterializeResult`) and the other had an additional unnecessary import (`get_dagster_logger`). This would be especially confusing for newbies, because `get_dagster_logger` isn't covered anywhere in the course. ## How I Tested These Changes It's just a markdown typo and the code now works in my Dagster University project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
One example code snippet was missing an import (
MaterializeResult) and the other had an additional unnecessary import (get_dagster_logger). This would be especially confusing for newbies, becauseget_dagster_loggerisn't covered anywhere in the course.How I Tested These Changes
It's just a markdown typo and the code now works in my Dagster University project.