Skip to content

Commit

Permalink
[daggy-u] Example code fixes for extra credit lesson in Dagster Essen…
Browse files Browse the repository at this point in the history
…tials (#25418)

## Summary & Motivation

One example code snippet was missing an import (`MaterializeResult`) and
the other had an additional unnecessary import (`get_dagster_logger`).
This would be especially confusing for newbies, because
`get_dagster_logger` isn't covered anywhere in the course.

## How I Tested These Changes

It's just a markdown typo and the code now works in my Dagster
University project.
  • Loading branch information
aleexharris authored Oct 22, 2024
1 parent d853b77 commit 0c1803a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ In Lesson 9, you created the `adhoc_request` asset. During materialization, the
At this point, the code for the `adhoc_request` asset should look like this:

```python
from dagster import Config, asset, MaterializeResult, MetadataValue, get_dagster_logger
from dagster import Config, asset, MaterializeResult, MetadataValue
from dagster_duckdb import DuckDBResource

import plotly.express as px
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ Let’s add metadata to the `taxi_trips_file` asset to demonstrate further. This

```python
import pandas as pd
from dagster import asset, MetadataValue
from dagster import asset, MetadataValue, MaterializeResult

@asset(
partitions_def=monthly_partition,
Expand Down

2 comments on commit 0c1803a

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagster-university ready!

✅ Preview
https://dagster-university-fg8t0ejq3-elementl.vercel.app

Built with commit 0c1803a.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagster-docs ready!

✅ Preview
https://dagster-docs-d83vlmixp-elementl.vercel.app
https://master.dagster.dagster-docs.io

Built with commit 0c1803a.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.