Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send the "action strings" when notifying #5166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't send the "action strings" when notifying #5166

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
999738b
Don't send the "action strings" when notifying
brong Mar 30, 2015
31be83b
sieve/script.c: actually remove the actions_string param
rjbs Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sieve/script.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ static int build_notify_message(sieve_interp_t *i,
static int send_notify_callback(sieve_interp_t *interp,
void *message_context,
void *script_context, notify_list_t *notify,
char *actions_string,
char *actions_string __attribute__((unused)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to just remove the actions_string parameter all together rather than just commenting out the place where it is used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, probably. :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

const char **errmsg)
{
sieve_notify_context_t nc;
Expand Down Expand Up @@ -462,7 +462,7 @@ static int send_notify_callback(sieve_interp_t *interp,
build_notify_message(interp, notify->message, message_context,
&out);
buf_appendcstr(&out, "\n\n");
buf_appendcstr(&out, actions_string);
/* buf_appendcstr(&out, actions_string); */

nc.message = buf_cstring(&out);
nc.fname = NULL;
Expand Down
Loading