Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send the "action strings" when notifying #5166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rjbs
Copy link
Collaborator

@rjbs rjbs commented Dec 11, 2024

These strings are largely useful for debugging, not end user consumption.

(This commit message was written by Ricardo Signes, replacing the previous internal Fastmail commit message. The code change is by Bron Gondwana.)

These strings are largely useful for debugging, not end user
consumption.

(This commit message was written by Ricardo Signes, replacing the
previous internal Fastmail commit message.  The code change is by Bron
Gondwana.)
@rjbs rjbs requested a review from ksmurchison December 11, 2024 17:01
@rjbs rjbs marked this pull request as ready for review December 11, 2024 17:01
@rjbs
Copy link
Collaborator Author

rjbs commented Dec 11, 2024

Marked do not merge until freeze is over.

sieve/script.c Outdated
@@ -430,7 +430,7 @@ static int build_notify_message(sieve_interp_t *i,
static int send_notify_callback(sieve_interp_t *interp,
void *message_context,
void *script_context, notify_list_t *notify,
char *actions_string,
char *actions_string __attribute__((unused)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to just remove the actions_string parameter all together rather than just commenting out the place where it is used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, probably. :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants