Skip to content

chore: require internal pr builds only for packaging artifacts #32940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
+3 −2
Merged

chore: require internal pr builds only for packaging artifacts #32940

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22a5f0c
chore: require internal pr builds only for packaging artifacts
cacieprins Nov 12, 2025
bd1e72d
ignore contributor prs for create-and-trigger-packaging-artifacts
cacieprins Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .circleci/src/pipeline/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,9 +317,10 @@ jobs:
- publish-binary
requires:
- node_modules_install
- approve-contributor-pr
- internal-pr-build
- external-pr-build
filters:
branches:
ignore: /^pull\/[0-9]+/
Copy link

@cursor cursor bot Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Workflow Breaks for External Contributor PRs

The create-and-trigger-packaging-artifacts job now filters out external PRs, but downstream jobs like test-npm-module-on-minimum-node-version, test-types-cypress-and-jest, binary-system-tests, and others require get-published-artifacts which depends on this job. These downstream jobs have no filters excluding external PRs, so they'll be blocked waiting for a dependency that never runs, breaking the workflow for external contributor PRs.

Fix in Cursor Fix in Web

Copy link
Member

@jennifer-shehane jennifer-shehane Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! that is the point!

- wait-for-binary-publish:
type: approval
requires:
Expand Down
Loading