-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore: require internal pr builds only for packaging artifacts #32940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| - external-pr-build | ||
| filters: | ||
| branches: | ||
| ignore: /^pull\/[0-9]+/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Workflow Breaks for External Contributor PRs
The create-and-trigger-packaging-artifacts job now filters out external PRs, but downstream jobs like test-npm-module-on-minimum-node-version, test-types-cypress-and-jest, binary-system-tests, and others require get-published-artifacts which depends on this job. These downstream jobs have no filters excluding external PRs, so they'll be blocked waiting for a dependency that never runs, breaking the workflow for external contributor PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! that is the point!
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ci/contrib-pr-no-pub-bin
|
| Run status |
|
| Run duration | 19m 07s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
1
|
|
|
12
|
|
|
1098
|
|
|
4
|
|
|
26593
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.48%
|
|
|---|---|
|
|
188
|
|
|
161
|
Accessibility
97.99%
|
|
|---|---|
|
|
4 critical
8 serious
2 moderate
2 minor
|
|
|
101
|
Tests for review
cypress/e2e/commands/window.cy.js • 1 failed test • 5x-driver-firefox
| Test | Artifacts | |||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ... > only logs once |
| |||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > throws when alias property is `0` |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/files.cy.js • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| src/cy/commands/files > #readFile > retries to read when ENOENT |
| |||||||||||||
| Test | Artifacts | |||||||
|---|---|---|---|---|---|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
| |||||||
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Screenshots
|
|
The first 5 flaky specs are shown, see all 12 specs in Cypress Cloud.
Additional details
This external workflow cannot be triggered for contributor PRs; currently the supporting approval job hangs because the external workflow is never triggered. This removes the initial external workflow job from contributor prs, which prevents the approval job from being added to the workflow.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Limits packaging artifact creation to internal branches by removing external/contributor requirements and adding a branch ignore filter for PR branches.
.circleci/src/pipeline/workflows/pull-request.yml):create-and-trigger-packaging-artifacts:requiresonapprove-contributor-prandexternal-pr-build.requires:node_modules_install,internal-pr-build.filters.branches.ignore: /^pull/[0-9]+/to exclude PR branches.Written by Cursor Bugbot for commit bd1e72d. This will update automatically on new commits. Configure here.