Skip to content

Conversation

@cacieprins
Copy link
Contributor

@cacieprins cacieprins commented Nov 12, 2025

  • Closes

Additional details

This external workflow cannot be triggered for contributor PRs; currently the supporting approval job hangs because the external workflow is never triggered. This removes the initial external workflow job from contributor prs, which prevents the approval job from being added to the workflow.

Steps to test

How has the user experience changed?

PR Tasks


Note

Limits packaging artifact creation to internal branches by removing external/contributor requirements and adding a branch ignore filter for PR branches.

  • CI Workflow (.circleci/src/pipeline/workflows/pull-request.yml):
    • create-and-trigger-packaging-artifacts:
      • Remove requires on approve-contributor-pr and external-pr-build.
      • Keep requires: node_modules_install, internal-pr-build.
      • Add filters.branches.ignore: /^pull/[0-9]+/ to exclude PR branches.

Written by Cursor Bugbot for commit bd1e72d. This will update automatically on new commits. Configure here.

@cacieprins cacieprins marked this pull request as ready for review November 12, 2025 20:54
- external-pr-build
filters:
branches:
ignore: /^pull\/[0-9]+/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Workflow Breaks for External Contributor PRs

The create-and-trigger-packaging-artifacts job now filters out external PRs, but downstream jobs like test-npm-module-on-minimum-node-version, test-types-cypress-and-jest, binary-system-tests, and others require get-published-artifacts which depends on this job. These downstream jobs have no filters excluding external PRs, so they'll be blocked waiting for a dependency that never runs, breaking the workflow for external contributor PRs.

Fix in Cursor Fix in Web

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! that is the point!

@cypress
Copy link

cypress bot commented Nov 12, 2025

cypress    Run #67294

Run Properties:  status check failed Failed #67294  •  git commit bd1e72de21: ignore contributor prs for create-and-trigger-packaging-artifacts
Project cypress
Branch Review ci/contrib-pr-no-pub-bin
Run status status check failed Failed #67294
Run duration 19m 07s
Commit git commit bd1e72de21: ignore contributor prs for create-and-trigger-packaging-artifacts
Committer Cacie Prins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 12
Tests that did not run due to a developer annotating a test with .skip  Pending 1098
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26593
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.48%
  Untested elements 188  
  Tested elements 161  
Accessibility  97.99%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

Tests for review

Failed  cypress/e2e/commands/window.cy.js • 1 failed test • 5x-driver-firefox

View Output

Test Artifacts
... > only logs once
    </td>
  </tr></table>
Flakiness  commands/querying/querying.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > throws when alias property is `0` Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  commands/files.cy.js • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
src/cy/commands/files > #readFile > retries to read when ENOENT
    </td>
  </tr></table>
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary
    </td>
  </tr></table>
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Screenshots

The first 5 flaky specs are shown, see all 12 specs in Cypress Cloud.

@cacieprins cacieprins merged commit 94c982f into develop Nov 13, 2025
85 of 91 checks passed
@cacieprins cacieprins deleted the ci/contrib-pr-no-pub-bin branch November 13, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants