Skip to content

fix: catch Cypress installation script download error #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MikeMcC399 wants to merge 1 commit into from
Closed

fix: catch Cypress installation script download error #1392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion factory/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ NODE_VERSION="${FACTORY_DEFAULT_NODE_VERSION}"

# Update the FACTORY_VERSION to deploy cypress/factory if you make changes to
# BASE_IMAGE, FACTORY_DEFAULT_NODE_VERSION, YARN_VERSION, factory.Dockerfile or installScripts
FACTORY_VERSION='5.11.5'
FACTORY_VERSION='5.11.6'

# Chrome versions: https://www.ubuntuupdates.org/package/google_chrome/stable/main/base/google-chrome-stable
# Linux/amd64 only
Expand Down
4 changes: 4 additions & 0 deletions factory/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change log

## 5.11.6

- When building an image that includes Cypress, ensure that a failed download results in a failure exit code. Fixes [#1391](https://github.com/cypress-io/cypress-docker-images/issues/1391).

## 5.11.5

- When importing PGP keys for Node.js, allow individual key imports to fail. Log an error and continue to build. Resolves an issue when there is a network connectivity problem to the fallback keyserver keyserver.ubuntu.com. Addressed in [#1385](https://github.com/cypress-io/cypress-docker-images/issues/1385).
Expand Down
9 changes: 5 additions & 4 deletions factory/installScripts/cypress/default.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
#! /bin/bash
set -e

# TODO: should typescript be versioned? Should it have it's own ARG for the factory?
# Typescript is installed to allow testing of .ts spec files.
# TODO: should TypeScript be versioned? Should it have its own ARG for the factory?
# TypeScript is installed to allow testing of .ts spec files.
npm install -g "cypress@${1}" typescript

# Loosen file priveleges for the cypress cache. The first time that cypress runs it will create a
# Loosen file privileges for the Cypress cache. The first time that Cypress runs, it will create a
# binary_state.json file if it hasn't already been created. This was causing issues with non-root
# users, they do not have access to write to this directory. Since this is a develompent docker container
# users who do not have access to write to this directory. Since this is a develompent Docker image
# and to lower barriers as much as possible, we are loosening privs to allow the binary_state.json file
# to be created. Previously this file was created by root when cypress verify was called, but this would
# apply to amd processors since cypress verify was not called on arm processors.
Expand Down