Skip to content

Conversation

@MikeMcC399
Copy link
Collaborator

Situation

If there is an npm install error in the shell installation script for Cypress factory/installScripts/cypress/default.sh, the script continues and does not pass the error to the caller. The exit code is then incorrect 0 (success):

child process exited with code 0

In the CircleCI config circle.yml, jobs which build and test images with Cypress included then fail when testing the image, instead of failing at the stage of image build. The image build reports success even if the npm install cypress step failed.

Change

In the script factory/installScripts/cypress/default.sh

  • use set -e to ensure that a failure in npm install is reflected in the process exit code

  • correct typos

  • bump FACTORY_VERSION to 5.11.6

@MikeMcC399 MikeMcC399 added the bug label Jul 25, 2025
@MikeMcC399 MikeMcC399 self-assigned this Jul 25, 2025
@cypress-app-bot
Copy link

@MikeMcC399
Copy link
Collaborator Author

  • This PR will not make PR chore: release 14.5.3 #1389 succeed. It just ensures that the error is reported in the correct place.
  • Given that this PR is succeeding (with 14.5.2) and PR chore: release 14.5.3 #1389 is failing, attempting to build and test 14.5.3, I would suspect a Cloudflare caching issue, however I don't have insight into how that works.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review July 25, 2025 17:42
@MikeMcC399
Copy link
Collaborator Author

Obsolete

@MikeMcC399 MikeMcC399 closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cypress install download error not caught by installation script

2 participants