fix: catch Cypress installation script download error #1392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
If there is an
npm installerror in the shell installation script for Cypress factory/installScripts/cypress/default.sh, the script continues and does not pass the error to the caller. The exit code is then incorrect0(success):In the CircleCI config circle.yml, jobs which build and test images with Cypress included then fail when testing the image, instead of failing at the stage of image build. The image build reports success even if the
npm install cypressstep failed.Change
In the script factory/installScripts/cypress/default.sh
use set -e to ensure that a failure in
npm installis reflected in the process exit codecorrect typos
bump
FACTORY_VERSIONto5.11.6