Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error importing empty parent in root #2766

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix error importing empty parent in root #2766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/actions/importFiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,12 @@ export const importFilesActionCreator =
)
const parentContext =
ancestors.length === 0 ? baseContext : [...unroot(baseContext), ...relativeAncestorContext]
// TODO: It would be better to get the id from importText rather than contextToPath
const parentPath = contextToPath(stateAfterPull, parentContext)

// Special handling for empty parent nodes
const parentPath =
parentContext.length === 1 && parentContext[0] === ''
? path // Use the current path for empty parent nodes
: contextToPath(stateAfterPull, parentContext)

// validate parentPath
if (!parentPath) {
Expand Down
Loading