Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error importing empty parent in root #2766

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RED-ROSE515
Copy link
Collaborator

This PR resolves the issue : Error importing empty parent in root #2167

Cause of the issue : There is a problem in handling the empty parents in import process. When we have an empty parent node, the context-to-path conversion is failing because it's treating the empty string as an invalid value.

Solution : I've modified the importFiles.ts file to handle empty parent nodes correctly. So, when I detect an empty parent node, I use the current path instead of trying to convert the empty context to a path.

Thanks.

@raineorshine
Copy link
Contributor

Thanks for your submission!

If the cause of the issue is related to contextToPath, I'm curious why you added a special case to importFiles rather than fixing the root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants