Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppeteer + MacOS #1845

Merged
merged 1 commit into from
May 4, 2024
Merged

Puppeteer + MacOS #1845

merged 1 commit into from
May 4, 2024

Conversation

raineorshine
Copy link
Contributor

Run on Mac since Puppeteer snapshots were generated on a Mac.
Otherwise snapshot tests will fail.

Related: #1836

@raineorshine raineorshine force-pushed the puppeteer-macos branch 2 times, most recently from 436d8b1 to f4aa398 Compare April 30, 2024 20:45
@raineorshine raineorshine merged commit 387f04a into main May 4, 2024
3 of 4 checks passed
@raineorshine raineorshine deleted the puppeteer-macos branch May 4, 2024 13:28
@raineorshine
Copy link
Contributor Author

raineorshine commented May 4, 2024

This PR started failing with the following error last week:

Error launching puppeteer: TimeoutError: Timed out after 30000 ms while trying to connect to the browser! Only Chrome at revision r869685 is guaranteed to work.

After further investigation, it appears to be an issue on GitHub's side, and not related to any specific commit in this repo. It has now passed twice in GitHub Actions: once in this PR and once in main on merge. Hopefully it is stable. If not, consider containerizing Puppeteer and running it in on ubuntu-latest (#1836).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant