-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containerize Puppeteer #1836
Containerize Puppeteer #1836
Conversation
81d0fd4
to
a7672ec
Compare
|
69eb46e
to
62a8ca7
Compare
62a8ca7
to
faece24
Compare
Attempting to containerize Puppeteer to generate uniform snapshots across platforms. Not yet integrated into GitHub Actions, but added two Docker-related scripts that can be run manually:
Resources:
Error running
|
The main GitHub issue for people having trouble getting chrome to launch: puppeteer/puppeteer#807
Now just getting the error:
|
faece24
to
1e3d58a
Compare
Closing since #1845 fixed Puppeteer on GitHubActions, which was the original reason to containerize. This can be reopened if the |
Update 2024-05-04: Puppeteer finally passes in GitHub Actions with the
macos-latest
test runner. This issue is now about running the Puppeteer tests in a Docker container. This would normalize browser rendering across platforms, albeit at the cost of additional test ops complexity.Puppeteer currently works locally but fails in GitHub Actions.