Split Dockerfile in two stages: builder and runtime. #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he size of the final image. This is because the build dependencies, which are not required in the final image, are excluded. You can create tags for each stage separately using the `--target` option: ```bash docker build --target builder -t pyceres:builder . docker build --target runtime -t pyceres:runtime . ``` However, if you run the `docker build` command without the `--target` option, it will build up to the last stage defined in the Dockerfile. So, running: ```bash docker build -t pyceres:latest . ``` is equivalent to specifying `--target runtime`, as runtime is the final stage in the Dockerfile.
|
I've removed the dependency on COLMAP - is the Docker size still an issue? |
|
If I do Which seems weird because it has a lot less dependencies. I guess you don't need the cuda image anymore: I would still recommend doing the builder/runtime split, since it is not really needed all the |
|
I quickly updated this PR locally, using regular ubuntu image and I get: edit: I added some runtime libraries |
pablospe
commented
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By dividing the Dockerfile into two stages, we significantly reduce the size of the final image. This is because the build dependencies, which are not required in the final image, are excluded.
You can create tags for each stage separately using the
--targetoption:However, if you run the
docker buildcommand without the--targetoption, it will build up to the last stage defined in the Dockerfile. So, running:docker build -t pyceres:latest .is equivalent to specifying
--target runtime, as runtime is the final stage in the Dockerfile.Reduction in size: