Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

III-4866 refactor EditPlaceRestController to 2 handlers-1/2-updateAddress() #1101

Merged
merged 15 commits into from
Aug 24, 2022
Merged

III-4866 refactor EditPlaceRestController to 2 handlers-1/2-updateAddress() #1101

merged 15 commits into from
Aug 24, 2022

Commits on Aug 22, 2022

  1. Create CommandHandler for UpdateAddress

    @JonasVHG
    JonasVHG committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    3916ddf View commit details
    Browse the repository at this point in the history

  2. make PlaceControllerProvider use CommandHandler for updateAddress

    @JonasVHG
    JonasVHG committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    120adce View commit details
    Browse the repository at this point in the history

  3. remove updateAddress from PlaceEditingServiceInterface

    @JonasVHG
    JonasVHG committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    adda4d9 View commit details
    Browse the repository at this point in the history

  4. remove tests for DefaultPlaceEditingService

    @JonasVHG
    JonasVHG committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    6496617 View commit details
    Browse the repository at this point in the history

  5. remove DefaultPlaceEditingService

    @JonasVHG
    JonasVHG committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b873a3f View commit details
    Browse the repository at this point in the history

  6. remove usages of DefaultPlaceEditingService

    @JonasVHG
    JonasVHG committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    6df20d5 View commit details
    Browse the repository at this point in the history

  7. remove test for updateAddress in EditPlaceRestController

    @JonasVHG
    JonasVHG committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    da6d2a9 View commit details
    Browse the repository at this point in the history

  8. remove updateAddress() & placeContext() from EditPlaceRestController

    @JonasVHG
    JonasVHG committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    6400a1e View commit details
    Browse the repository at this point in the history

  9. set tests for UpdateAddressRequestHandler

    @JonasVHG
    JonasVHG committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    0c0d20b View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Add tests for UpdateAddressRequestHandler

    @JonasVHG
    JonasVHG committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    69695a9 View commit details
    Browse the repository at this point in the history

  2. Improve naming of variables

    @JonasVHG
    JonasVHG committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    81d07c4 View commit details
    Browse the repository at this point in the history

  3. check If NoContentResponse is Returned

    @JonasVHG
    JonasVHG committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    d8b8e06 View commit details
    Browse the repository at this point in the history

  4. use dataprovider to check for multiple empty values

    @JonasVHG
    JonasVHG committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    201b69f View commit details
    Browse the repository at this point in the history

  5. remove duplicate check for DocumentNotFound

    @JonasVHG
    JonasVHG committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    928b21a View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. remove unnecessary variable

    @JonasVHG
    JonasVHG committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    8ababa9 View commit details
    Browse the repository at this point in the history